-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add e2e test for abort
in renderer loaded native module
#617
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great package name
Oh, it's completely stolen from the Rust crate that it wraps. I think we can thank @Jake-Shadle for this 🤣 |
The Windows test failures show that Electron notifies us of the renderer crash but no minidump was found:
|
I added some crude retrying and it appears there just isn't a minidump generated for abort on Windows:
|
…ndows" This reverts commit c2c7b5b.
huh - is that something that is just a limitation for electron? |
The docs for
So it could be that Crashpad on Windows doesn't cater for whatever Rust + Just testing with the upstream Electron reporter now... |
fadf50c
to
9361a1c
Compare
Yes, confirmed that the Electron I want to double check C |
With the following basic Node-API module I get minidumps on macOS and Linux but nothing on Windows. That suggest this is an upstream issue with Electron. #include <node_api.h>
#include <stdlib.h>
namespace demo
{
napi_value Method(napi_env env, napi_callback_info args)
{
abort();
return nullptr;
}
napi_value init(napi_env env, napi_value exports)
{
napi_status status;
napi_value fn;
status = napi_create_function(env, nullptr, 0, Method, nullptr, &fn);
if (status != napi_ok)
return nullptr;
status = napi_set_named_property(env, exports, "abort", fn);
if (status != napi_ok)
return nullptr;
return exports;
}
NAPI_MODULE(NODE_GYP_MODULE_NAME, init)
} |
Just merged from master to see if this has been fixed in any of the recent versions of Electron... |
Uses
sadness-generator
native module to test abort.